Skip to content

feat: influence parameter defaults through cli flag/env #13039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2024
Merged

feat: influence parameter defaults through cli flag/env #13039

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b21a0e
feat: influence parameter defaults through cli flag/env
aaronlehmann Apr 22, 2024
abaee39
Rename defaults arg to defaultOverrides
aaronlehmann Apr 29, 2024
f6b533b
Merge branch 'main' into parameter-defaults
aaronlehmann Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename defaults arg to defaultOverrides
  • Loading branch information
@aaronlehmann
aaronlehmann committed Apr 29, 2024
commit abaee392e6cd9667e415b9ad87c23643d3b52392
4 changes: 2 additions & 2 deletions cli/cliui/parameter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/coder/serpent"
)

func RichParameter(inv *serpent.Invocation, templateVersionParameter codersdk.TemplateVersionParameter, defaults map[string]string) (string, error) {
func RichParameter(inv *serpent.Invocation, templateVersionParameter codersdk.TemplateVersionParameter, defaultOverrides map[string]string) (string, error) {
label := templateVersionParameter.Name
if templateVersionParameter.DisplayName != "" {
label = templateVersionParameter.DisplayName
Expand All @@ -27,7 +27,7 @@ func RichParameter(inv *serpent.Invocation, templateVersionParameter codersdk.Te
}

defaultValue := templateVersionParameter.DefaultValue
if v, ok := defaults[templateVersionParameter.Name]; ok {
if v, ok := defaultOverrides[templateVersionParameter.Name]; ok {
defaultValue = v
}

Expand Down