Skip to content

fix(cli): scaletest: ignore errors syncing output #13076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix(cli): scaletest: ignore errors syncing output #13076

merged 1 commit into from
Apr 26, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Apr 25, 2024 •
edited
Loading

There isn't much we can do if it fails, and it leads to spurious error messages on some platforms.

@johnstcn johnstcn self-assigned this Apr 25, 2024
@johnstcn johnstcn marked this pull request as ready for review April 25, 2024 17:48
@johnstcn johnstcn requested review from mafredri and mtojek and removed request for mafredri April 25, 2024 17:48
mtojek
mtojek approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp 👍

@johnstcn johnstcn merged commit 365231b into main Apr 26, 2024
32 checks passed
@johnstcn johnstcn deleted the cj/scaletest-ignore-sync-error branch April 26, 2024 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @mafredri @mtojek