Skip to content

chore: correct name for github enterprise example #13083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2024
Merged

chore: correct name for github enterprise example #13083

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a665258
chore: correct name for github enterprise example
michaelbrewer Apr 25, 2024
4ed0f48
Update external-auth.md
michaelbrewer Apr 25, 2024
cd4ab2e
Update external-auth.md
michaelbrewer Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: correct name for github enterprise example
  • Loading branch information
@michaelbrewer
michaelbrewer authored Apr 25, 2024
commit a665258385ae47e8d9fa3842b241bfb092cfa093
2 changes: 1 addition & 1 deletion docs/admin/external-auth.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ GitHub Enterprise requires the following environment variables:

```env
CODER_EXTERNAL_AUTH_0_ID="primary-github"
CODER_EXTERNAL_AUTH_0_TYPE=github-enterprise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick code search shows that we are not using the type github-enterprise anywhere. So this change looks good to me.

CODER_EXTERNAL_AUTH_0_TYPE=github
CODER_EXTERNAL_AUTH_0_CLIENT_ID=xxxxxx
CODER_EXTERNAL_AUTH_0_CLIENT_SECRET=xxxxxxx
CODER_EXTERNAL_AUTH_0_VALIDATE_URL="https://github.example.com/api/v3/user"
Expand Down