Skip to content

fix(site): fix template schedule options #13084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Apr 26, 2024

Screen.Recording.2024-04-26.at.09.54.58.mov

Closes #13082

@BrunoQuaresma BrunoQuaresma requested review from stirby, a team and aslilac and removed request for a team April 26, 2024 12:57
Copy link

github-actions bot commented Apr 26, 2024


✔️ PR 13084 Updated successfully.
🚀 Access the credentials here.

cc: @BrunoQuaresma

@BrunoQuaresma
Copy link
Collaborator Author

@stirby I'm deploying this PR so you can do some QA before we merge it.

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the option descriptions. Will approve after testing but should also get @aslilac's approval

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, left a bunch of comments on friday and then didn't submit 😵‍💫

* buttons, checkboxes, or switches to ensure proper styling.
*/

export const StackLabel: FC<ComponentProps<typeof Stack>> = (props) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just import StackProps

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StackProps does not work very well because of theForwardProps.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-04-29 at 14 13 06

@BrunoQuaresma BrunoQuaresma merged commit 053c56c into main Apr 29, 2024
26 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-schedule-options branch April 29, 2024 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template schedule settings refactor - fixes
3 participants