Skip to content

feat: sign windows binaries #13086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 29, 2024
Merged

feat: sign windows binaries #13086

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
43c1463
feat: sign windows binaries
sreya Apr 27, 2024
29f5da3
typo
sreya Apr 27, 2024
d4ae773
java
sreya Apr 27, 2024
cd2b975
whoops
sreya Apr 27, 2024
00ba1bf
checkout first
sreya Apr 27, 2024
535bdff
access-token
sreya Apr 27, 2024
d0cc85e
idk
sreya Apr 27, 2024
156b5ea
wrong principal
sreya Apr 27, 2024
f136fa1
test token
sreya Apr 27, 2024
f7879a7
wrong format
sreya Apr 27, 2024
6fad022
big O
sreya Apr 27, 2024
ea9afe9
i mean wtf
sreya Apr 27, 2024
902bff8
update CI workflow
sreya Apr 27, 2024
640cc1b
update windows script comment
sreya Apr 27, 2024
40449b8
remove test release workflow
sreya Apr 27, 2024
afc9564
make fmt
sreya Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
access-token
  • Loading branch information
@sreya
sreya committed Apr 27, 2024
commit 535bdff2f98be250aef6a07bc81fba05f2790f66
3 changes: 3 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@ jobs:
fetch-depth: 0

- name: Authenticate to Google Cloud
id: gcloud_auth
uses: google-github-actions/auth@v2
with:
workload_identity_provider: ${{ secrets.GCP_WORKLOAD_ID_PROVIDER }}
service_account: ${{ secrets.GCP_CODE_SIGNING_SERVICE_ACCOUNT }}
token_format: "access_token"

- name: Setup GCloud SDK
uses: "google-github-actions/setup-gcloud@v2"
Expand Down Expand Up @@ -142,6 +144,7 @@ jobs:
EV_KEYSTORE: ${{ secrets.EV_KEYSTORE }}
EV_TSA_URL: ${{ secrets.EV_TSA_URL }}
EV_CERTIFICATE_PATH: /tmp/ev_cert.pem
GCLOUD_ACCESS_TOKEN: ${{ steps.gcloud_auth.outputs.access_token }}
JSIGN_PATH: /tmp/jsign-6.0.jar

- name: Delete Apple Developer certificate and API key
Expand Down
2 changes: 1 addition & 1 deletion scripts/build_go.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ fi

if [[ "$sign_windows" == 1 ]]; then
dependencies java
requiredenvs JSIGN_PATH EV_KEYSTORE EV_KEY EV_CERTIFICATE_PATH EV_TSA_URL
requiredenvs JSIGN_PATH EV_KEYSTORE EV_KEY EV_CERTIFICATE_PATH EV_TSA_URL GCLOUD_ACCESS_TOKEN
fi

ldflags=(
Expand Down
4 changes: 2 additions & 2 deletions scripts/sign_windows.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ source "$(dirname "${BASH_SOURCE[0]}")/lib.sh"

# Check dependencies
dependencies java
requiredenvs JSIGN_PATH EV_KEYSTORE EV_KEY EV_CERTIFICATE_PATH EV_TSA_URL
requiredenvs JSIGN_PATH EV_KEYSTORE EV_KEY EV_CERTIFICATE_PATH EV_TSA_URL GCLOUD_ACCESS_TOKEN

java -jar "$JSIGN_PATH" \
--storetype GOOGLECLOUD \
--storepass "$(gcloud auth print-access-token)" \
--storepass "$GCLOUD_ACCESS_TOKEN" \
--keystore "$EV_KEYSTORE" \
--alias "$EV_KEY" \
--certfile "$EV_CERTIFICATE_PATH" \
Expand Down
Loading