feat: add deployment_id to the ui and licenses
#13096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpaulsen
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
i'll let @johnstcn reviewing the go code - but the UI LGTM.
Parkreiner
reviewed
Apr 29, 2024
site/src/modules/dashboard/Navbar/UserDropdown/UserDropdownContent.tsx
Outdated
Show resolved
Hide resolved
Parkreiner
reviewed
Apr 29, 2024
site/src/modules/dashboard/Navbar/UserDropdown/UserDropdownContent.tsx
Outdated
Show resolved
Hide resolved
matifali
reviewed
Apr 29, 2024
| @@ -17,6 +17,9 @@ | |||
| }, | |||
| { | |||
| "pattern": "tailscale.com" | |||
| }, | |||
| { | |||
| "pattern": "wireguard.com" | |||
|
@kylecarbs it is not showing up on dev.coder.com although the version v2.10.0-devel+1bda8a085 have been deployed successfully. |
|
Hmm, I'll check why that is. Odd |
|
@matifali fixed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows customers to send us the deployment ID easily. I put this in the user dropdown because it's so global. If users find this confusing, we can happily move it!
Soon, licenses can be generated with specific deployment IDs to match against. This is to prevent customers from having a bunch of Coder deployments with the same license.