Skip to content

feat: Add update user password endpoint #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 6, 2022
Merged

feat: Add update user password endpoint #1310

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
346e5e4
Add UpdateUserHashedPassword query
BrunoQuaresma May 4, 2022
4bd7557
chore: Merge branch 'main' of github.com:coder/coder into bq/update-u…
BrunoQuaresma May 4, 2022
de39cf5
Add database functions
BrunoQuaresma May 5, 2022
2fe1716
Add update user password endpoint
BrunoQuaresma May 5, 2022
212020a
Add tests and fixes
BrunoQuaresma May 5, 2022
2699445
Remove confirmation and fix lint issues
BrunoQuaresma May 5, 2022
355f163
Return hash error as server error
BrunoQuaresma May 5, 2022
56b29fd
Update coderd/database/databasefake/databasefake.go
BrunoQuaresma May 5, 2022
30b8f15
Improve readbility
BrunoQuaresma May 5, 2022
f6be255
Add RBAC
BrunoQuaresma May 5, 2022
5df5763
Fix route
BrunoQuaresma May 5, 2022
b9dbd64
Merge branch 'bq/update-user-password' of github.com:coder/coder into…
BrunoQuaresma May 5, 2022
69af903
Add missing TS types
BrunoQuaresma May 5, 2022
d85092b
Update update password request params
BrunoQuaresma May 5, 2022
96ce751
Remove confirm password from the API
BrunoQuaresma May 5, 2022
4f9f506
Update coderd/users.go
BrunoQuaresma May 5, 2022
671c56d
Remove user restriction and refactor tests
BrunoQuaresma May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Return hash error as server error
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 5, 2022
commit 355f1631928a87675275d58ed2b4656e70fdff57
13 changes: 7 additions & 6 deletions coderd/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,12 @@ func (api *api) putUserSuspend(rw http.ResponseWriter, r *http.Request) {
httpapi.Write(rw, http.StatusOK, convertUser(suspendedUser, organizations))
}

func (api *api) putUserPassword(rw http.ResponseWriter, r *http.Request) error {
func (api *api) putUserPassword(rw http.ResponseWriter, r *http.Request) {
user := httpmw.UserParam(r)

var params codersdk.UpdateUserPasswordRequest
if !httpapi.Read(rw, r, &params) {
return nil
return
}

// Check if the new password and the confirmation match
Expand All @@ -380,13 +380,15 @@ func (api *api) putUserPassword(rw http.ResponseWriter, r *http.Request) error {
Message: fmt.Sprintf("The new password and the new password confirmation don't match"),
Errors: requestErrors,
})
return nil
return
}

// Hash password and update it in the database
hashedPassword, hashError := userpassword.Hash(params.NewPassword)
if hashError != nil {
return xerrors.Errorf("hash password: %w", hashError)
httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{
Message: fmt.Sprintf("hash password: %s", hashError.Error()),
})
}
databaseError := api.Database.UpdateUserHashedPassword(r.Context(), database.UpdateUserHashedPasswordParams{
ID: user.ID,
Expand All @@ -396,11 +398,10 @@ func (api *api) putUserPassword(rw http.ResponseWriter, r *http.Request) error {
httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{
Message: fmt.Sprintf("put user password: %s", databaseError.Error()),
})
return nil
return
}

httpapi.Write(rw, http.StatusNoContent, nil)
return nil
}

func (api *api) userRoles(rw http.ResponseWriter, r *http.Request) {
Expand Down