Skip to content

chore: remove GITHUB_TOKEN from dogfood env vars #13106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: remove GITHUB_TOKEN from dogfood env vars #13106

merged 1 commit into from
Apr 30, 2024

Conversation

kylecarbs
Copy link
Member

This was stale all the time!

@kylecarbs kylecarbs self-assigned this Apr 30, 2024
@kylecarbs kylecarbs enabled auto-merge (squash) April 30, 2024 01:23
cdr-bot[bot]
cdr-bot bot approved these changes Apr 30, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@kylecarbs kylecarbs mentioned this pull request Apr 30, 2024
Merged
@kylecarbs kylecarbs merged commit d302570 into main Apr 30, 2024
@kylecarbs kylecarbs deleted the dogfoodenv branch April 30, 2024 01:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
@matifali
Copy link
Member

matifali commented Apr 30, 2024 •
edited
Loading

We use the gh CLI in release and deploy-pr scripts. So we should now update the scripts to add a line to get a fresh GitHub token on demand.
export GITHUB_TOKEN=$(coder external-auth access-token github)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @matifali