Skip to content

fix(site): fix template schedule update overriding other settings #13114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2024
Merged

fix(site): fix template schedule update overriding other settings #13114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6a2fe4
Improve design
BrunoQuaresma Apr 30, 2024
425d55b
Fix require_active_version getting overrided
BrunoQuaresma Apr 30, 2024
65a2a2d
Add test to verify template updated data
BrunoQuaresma Apr 30, 2024
b84faff
Add back enterprise badge and adjust spacing
BrunoQuaresma May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test to verify template updated data
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Apr 30, 2024
commit 65a2a2d00ab4cc4f6e63aaee2c4bee8e2f2344e8
2 changes: 1 addition & 1 deletion site/e2e/tests/listTemplates.spec.ts → ...e2e/tests/templates/listTemplates.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { test, expect } from "@playwright/test";
import { beforeCoderTest } from "../hooks";
import { beforeCoderTest } from "../../hooks";

test.beforeEach(({ page }) => beforeCoderTest(page));

Expand Down
45 changes: 45 additions & 0 deletions site/e2e/tests/templates/updateTemplateSchedule.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import { expect, test } from "@playwright/test";
import { createTemplate, createTemplateVersion, getTemplate } from "api/api";
import { getCurrentOrgId, setupApiCalls } from "../../api";
import { beforeCoderTest } from "../../hooks";

test.beforeEach(({ page }) => beforeCoderTest(page));

test("update template schedule settings without override other settings", async ({
page,
baseURL,
}) => {
await setupApiCalls(page);
const orgId = await getCurrentOrgId();
const templateVersion = await createTemplateVersion(orgId, {
storage_method: "file" as const,
provisioner: "echo",
user_variable_values: [],
example_id: "docker",
tags: {},
});
const template = await createTemplate(orgId, {
name: "test-template",
display_name: "Test Template",
template_version_id: templateVersion.id,
disable_everyone_group_access: false,
require_active_version: true,
});

await page.goto(`${baseURL}/templates/${template.name}/settings/schedule`, {
waitUntil: "domcontentloaded",
});
await page.getByLabel("Default autostop (hours)").fill("48");
await page.getByRole("button", { name: "Submit" }).click();
await expect(page.getByText("Template updated successfully")).toBeVisible();

const updatedTemplate = await getTemplate(template.id);
// Validate that the template data remains consistent, with the exception of
// the 'default_ttl_ms' field (updated during the test) and the 'updated at'
// field (automatically updated by the backend).
expect({
...template,
default_ttl_ms: 48 * 60 * 60 * 1000,
updated_at: updatedTemplate.updated_at,
}).toStrictEqual(updatedTemplate);
});