chore: cover deadline crossing autostart border #13115
Conversation
| // - This crosses the autostart deadline, so the deadline is extended to 9pm | ||
| nextAutostart, ok := NextAutostartSchedule(params.Now, params.WorkspaceAutostart, templateSchedule) | ||
| if ok && autostop.Deadline.After(nextAutostart) { | ||
| autostop.Deadline = nextAutostart.Add(ttl) |
There was a problem hiding this comment.
Do we need to handle the min(deadline, max_deadline) here too?
There was a problem hiding this comment.
No, that is handled down below.
coder/coderd/schedule/autostop.go
Line 238 in 94872aa
I'd rather not duplicate that logic since it also handles the case where MaxDeadline is not set.
| templateAutostopRequirement: schedule.TemplateAutostopRequirement{}, | ||
| userQuietHoursSchedule: "", | ||
|
|
||
| expectedDeadline: time.Date(pastDateNight.Year(), pastDateNight.Month(), pastDateNight.Day()+1, 21, 0, 0, 0, chicago), |
There was a problem hiding this comment.
could you use pastDateNight.AddDate() here?
There was a problem hiding this comment.
AddDate cannot add hours. So it would be AddDate(0,0,1).Add(time.Hour*X) But the number of hours is 23.25 hours, which is such a strange amount.
pastDateNight = 9:45pm on Wednesday
expectedDeadline = 9pm Thursday, which is 12hrs + autostart (which is a cron string, not a Go time.Time).
It was easier for me to reason because the offset being 23.25 hours is not really the assertion I am making. I want to assert it's 12hrs after autostart.
Closes #12864
This PR adds the second case in this image. If a user starts a workspace, and that TTL crosses the next autostart, the deadline is set to autostart + TTL