Skip to content

fix: Restore terminal on interrupt when connecting #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2022
Merged

fix: Restore terminal on interrupt when connecting #1312

merged 1 commit into from
May 6, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #1292.

@kylecarbs kylecarbs requested a review from coadler May 5, 2022 21:25
@kylecarbs kylecarbs self-assigned this May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #1312 (22a709b) into main (568574c) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
- Coverage   66.18%   66.18%   -0.01%     
==========================================
  Files         281      281              
  Lines       18424    18438      +14     
  Branches      220      220              
==========================================
+ Hits        12194    12203       +9     
- Misses       4971     4976       +5     
  Partials     1259     1259
Flag Coverage Δ
unittest-go-macos-latest 53.50% <66.66%> (-0.04%) ⬇️
unittest-go-postgres- 65.01% <66.66%> (-0.07%) ⬇️
unittest-go-ubuntu-latest 55.94% <66.66%> (-0.02%) ⬇️
unittest-go-windows-2022 51.92% <66.66%> (-0.01%) ⬇️
unittest-js 71.61% <ø> (ø)
Impacted Files Coverage Δ
cli/cliui/agent.go 77.46% <64.28%> (+0.27%) ⬆️
provisionerd/provisionerd.go 76.17% <100.00%> (-0.54%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
coderd/provisionerdaemons.go 62.98% <0.00%> (-0.51%) ⬇️
peer/channel.go 85.96% <0.00%> (ø)
provisioner/terraform/provision.go 72.30% <0.00%> (+0.40%) ⬆️
peer/conn.go 81.57% <0.00%> (+0.73%) ⬆️
provisionersdk/serve.go 43.24% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568574c...22a709b. Read the comment docs.

@kylecarbs kylecarbs merged commit 914a2f4 into main May 6, 2022
@kylecarbs kylecarbs deleted the restoreterm branch May 6, 2022 01:11
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Restore terminal on interrupt when connecting (#1312)
60142d8 
Fixes #1292.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

coder ssh should reset TTY state on SIGINT
3 participants
@kylecarbs @coadler @misskniss