feat: move shared ports out of experiment #13120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0ssel
commented
May 1, 2024
Comment on lines
+514
to
+516
| if len(codersdk.ExperimentsAll) == 0 { | ||
| t.Skip("No experiments are currently defined; skipping test.") | ||
| } |
There was a problem hiding this comment.
@dannykopping I see these prom metrics are somewhat assuming that the len(codersdk.ExperimentsAll) will always be at least > 0, but with the removal of shared ports we currently have an empty slice for it and it's failing these tests. Let me know if you'd like me to do something besides skipping these under that condition in this PR. Thanks
There was a problem hiding this comment.
We spoke offline, he gave me the 👍 for now and we'll make the changes to get these tests running again soon.
deansheather
approved these changes
May 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes part of #13058
Before with no experiment enabled:
After with enterprise license:
After without license:
