Skip to content

chore: enable playwright test extension in vscode #13135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2024
Merged

chore: enable playwright test extension in vscode #13135

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19629c1
chore: enable playwright test extension in vscode
Emyrk May 2, 2024
860a28b
revert package changes
Emyrk May 2, 2024
afd1b71
revert git ignore
Emyrk May 2, 2024
c65d49c
Add to readme for debugger in nix
Emyrk May 2, 2024
d6f15b3
make fmt
Emyrk May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion site/e2e/reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,14 @@ class CoderReporter implements Reporter {
}
}

const logLines = (chunk: string): string[] => chunk.trimEnd().split("\n");
const logLines = (chunk: string | Buffer): string[] => {
if (chunk instanceof Buffer) {
// When running in a debugger, the input to this is a Buffer instead of a string.
// Unsure why, but this prevents the `trimEnd` from throwing an error.
return [chunk.toString()];
}
return chunk.trimEnd().split("\n");
};
Comment on lines +136 to +143
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugger fails without this


const exportDebugPprof = async (outputFile: string) => {
const response = await axiosInstance.get(
Expand Down