Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4da94ef
fix: remove some of the jank around our core App component
Parkreiner May 2, 2024
9986024
refactor: scope navigation logic more aggressively
Parkreiner May 2, 2024
7004c9c
refactor: add explicit return type to useAuthenticated
Parkreiner May 2, 2024
ebfaec5
refactor: clean up ProxyContext code
Parkreiner May 2, 2024
1192eb3
wip: add code for consolidating the HTML metadata
Parkreiner May 2, 2024
bbe2ae0
refactor: clean up hook logic
Parkreiner May 2, 2024
1c41937
refactor: rename useHtmlMetadata to useEmbeddedMetadata
Parkreiner May 2, 2024
79e9c45
fix: correct names that weren't updated
Parkreiner May 2, 2024
81f2cd9
fix: update type-safety of useEmbeddedMetadata further
Parkreiner May 2, 2024
390418f
wip: switch codebase to use metadata hook
Parkreiner May 3, 2024
486f292
Merge branch 'main' into mes/login-fix
Parkreiner May 3, 2024
b77af73
Merge branch 'mes/login-fix' of https://github.com/coder/coder into m…
Parkreiner May 3, 2024
e072f7a
refactor: simplify design of metadata hook
Parkreiner May 3, 2024
2a58322
fix: update stray type mismatches
Parkreiner May 3, 2024
b55abb7
fix: more type fixing
Parkreiner May 3, 2024
c45e1b7
fix: resolve illegal invocation error
Parkreiner May 3, 2024
2a63c1d
fix: get metadata issue resolved
Parkreiner May 3, 2024
4d3b155
fix: update comments
Parkreiner May 3, 2024
8067e77
chore: add unit tests for MetadataManager
Parkreiner May 3, 2024
5e6e974
fix: beef up tests
Parkreiner May 3, 2024
772b96f
fix: update typo in tests
Parkreiner May 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: correct names that weren't updated
  • Loading branch information
Parkreiner committed May 2, 2024
commit 79e9c450a153deaee52959632db4587e30be6a4d
12 changes: 6 additions & 6 deletions site/src/hooks/useEmbeddedMetadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,15 @@ export class MetadataManager implements MetadataManagerApi {
};
}

type UseHtmlMetadataResult = Readonly<{
type UseEmbeddedMetadataResult = Readonly<{
metadata: RuntimeHtmlMetadata;
clearMetadataByKey: MetadataManager["clearMetadataByKey"];
}>;

export function makeUseHtmlMetadata(
export function makeUseEmbeddedMetadata(
manager: MetadataManager,
): () => UseHtmlMetadataResult {
return function useHtmlMetadata(): UseHtmlMetadataResult {
): () => UseEmbeddedMetadataResult {
return function useEmbeddedMetadata(): UseEmbeddedMetadataResult {
// Hook binds re-renders to the memory reference of the entire exposed
// metadata object, meaning that even if you only care about one value,
// using the hook will cause a component to re-render if the object changes
Expand All @@ -187,7 +187,7 @@ export function makeUseHtmlMetadata(
manager.getMetadata,
);

const stableMetadataResult = useMemo<UseHtmlMetadataResult>(() => {
const stableMetadataResult = useMemo<UseEmbeddedMetadataResult>(() => {
return {
metadata,
clearMetadataByKey: manager.clearMetadataByKey,
Expand All @@ -199,4 +199,4 @@ export function makeUseHtmlMetadata(
}

const defaultManager = new MetadataManager();
export const useHtmlMetadata = makeUseHtmlMetadata(defaultManager);
export const useEmbeddedMetadata = makeUseEmbeddedMetadata(defaultManager);
157 changes: 0 additions & 157 deletions site/src/hooks/useHtmlMetadata.ts

This file was deleted.