Skip to content

feat: add audit exporting and filtering #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2022
Merged

feat: add audit exporting and filtering #1314

merged 6 commits into from
May 9, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented May 5, 2022

Resolves #469

@coadler coadler self-assigned this May 5, 2022
@coadler coadler requested a review from kylecarbs May 5, 2022 22:26
@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #1314 (435940a) into main (ac27f64) will decrease coverage by 0.16%.
The diff coverage is 70.31%.

@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   66.49%   66.33%   -0.17%     
==========================================
  Files         284      284              
  Lines       18593    18456     -137     
  Branches      235      235              
==========================================
- Hits        12364    12242     -122     
+ Misses       4962     4954       -8     
+ Partials     1267     1260       -7
Flag Coverage Δ
unittest-go-macos-latest 53.71% <70.31%> (+0.10%) ⬆️
unittest-go-postgres- 65.16% <70.31%> (-0.08%) ⬇️
unittest-go-ubuntu-latest 56.12% <70.31%> (+0.04%) ⬆️
unittest-go-windows-2022 ?
unittest-js 73.67% <ø> (ø)
Impacted Files Coverage Δ
coderd/database/queries.sql.go 78.14% <0.00%> (ø)
coderd/audit/exporter.go 60.00% <60.00%> (ø)
coderd/audit/backends/postgres.go 69.23% <69.23%> (ø)
coderd/audit/backends/slog.go 83.33% <83.33%> (ø)
coderd/audit/filter.go 100.00% <100.00%> (ø)
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
cli/configssh.go 62.04% <0.00%> (-6.57%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac27f64...435940a. Read the comment docs.

kylecarbs
kylecarbs approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an extremely clean package. Bravo 👏

@coadler coadler enabled auto-merge (squash) May 9, 2022 21:58
@coadler coadler merged commit 20caee1 into main May 9, 2022
@coadler coadler deleted the colin/audit-exporter branch May 9, 2022 22:05
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@coadler @kylecarbs
feat: add audit exporting and filtering (#1314)
bdbc092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Create generic filter system to allow us to only export some audit logs
3 participants
@coadler @kylecarbs @misskniss