Skip to content

fix: add more tests for metadata hook functionality #13145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

fix: add more tests for metadata hook functionality #13145

merged 1 commit into from
May 3, 2024

Conversation

Parkreiner
Copy link
Member

Addendum to #13137

Changes made

  • Added a couple of test cases I thought of after making the original commit

@Parkreiner Parkreiner self-assigned this May 3, 2024
cdr-bot[bot]
cdr-bot bot approved these changes May 3, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner enabled auto-merge (squash) May 3, 2024 15:21
@Parkreiner Parkreiner merged commit 34a3bdc into main May 3, 2024
@Parkreiner Parkreiner deleted the mes/metadata-deletion-test-hotfix branch May 3, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Parkreiner