feat: Add DevURL support #1316
Closed
feat: Add DevURL support #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
- Coverage 66.28% 58.06% -8.22%
==========================================
Files 281 284 +3
Lines 18438 18752 +314
Branches 220 235 +15
==========================================
- Hits 12221 10888 -1333
- Misses 4962 6697 +1735
+ Partials 1255 1167 -88
Continue to review full report at Codecov.
|
This adds apps as a property to a workspace agent. The resource is added to the Terraform provider here: coder/terraform-provider-coder#17 Apps will be opened in the dashboard or via the CLI with `coder open <name>`. If `command` is specified, a terminal will appear locally and in the web. If `target` is specified, the browser will open to an exposed instance of that target.
deansheather
reviewed
May 9, 2022
Comment on lines
1
to
19
| -- name: GetWorkspaceAppsByAgentID :many | ||
| SELECT * FROM workspace_apps WHERE agent_id = $1; | ||
|
|
||
| -- name: GetWorkspaceAppsByAgentIDs :many | ||
| SELECT * FROM workspace_apps WHERE agent_id = ANY(@ids :: uuid [ ]); | ||
|
|
||
| -- name: InsertWorkspaceApp :one | ||
| INSERT INTO | ||
| workspace_apps ( | ||
| id, | ||
| created_at, | ||
| agent_id, | ||
| name, | ||
| icon, | ||
| command, | ||
| target | ||
| ) | ||
| VALUES | ||
| ($1, $2, $3, $4, $5, $6, $7) RETURNING *; |
There was a problem hiding this comment.
If these are only specified in the template, why are they defined on a per-agent basis instead of a per-template basis?
There was a problem hiding this comment.
You could technically have a dynamic DevURL based on input parameters.
| @@ -645,6 +645,27 @@ func insertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid. | |||
| if err != nil { | |||
| return xerrors.Errorf("insert agent: %w", err) | |||
| } | |||
|
|
|||
| for _, app := range agent.Apps { | |||
| _, err := db.InsertWorkspaceApp(ctx, database.InsertWorkspaceAppParams{ | |||
There was a problem hiding this comment.
What happens if an app is added to or removed from the template?
There was a problem hiding this comment.
Because templates are versioned and so are our builds, we won't have these problems!
|
Is this PR still blocked by @deansheather's Port forwarding code? |
|
Yup, I'm reviewing his now! |
This was referenced May 24, 2022
Abstracting coderd into an interface added misdirection because the interface was never intended to be fulfilled outside of a single implementation. This lifts the abstraction, and attaches all handlers to a root struct named `*coderd.API`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds DevURLs as a property to a workspace agent.
The resource is added to the Terraform provider here:
coder/terraform-provider-coder#17
DevURLs will be opened in the dashboard or via the CLI
with
coder open <name>. Ifcommandis specified, aterminal will appear locally and in the web. If
targetis specified, the browser will open to an exposed instance
of that target.
Todo:
coder opencommand to open a DevURL via the CLI.