Skip to content

fix: check if context is nil when logging coordination delete errors #13192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: check if context is nil when logging coordination delete errors #13192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: check if context is nil when logging coordination delete errors 
I'm not exactly sure how to handle this idiomatically...

See: https://github.com/coder/coder/actions/runs/8976564938/job/24653672411
  • Loading branch information
@kylecarbs
kylecarbs committed May 6, 2024
commit 8e41ada8f4c9bdfcfe0a02dcc8646c4fd776d77b
6 changes: 5 additions & 1 deletion enterprise/tailnet/pgcoord.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1654,7 +1654,11 @@ func (h *heartbeats) sendDelete() {
ctx := dbauthz.As(context.Background(), pgCoordSubject)
err := h.store.DeleteCoordinator(ctx, h.self)
if err != nil {
h.logger.Error(h.ctx, "failed to send coordinator delete", slog.Error(err))
// If this errors and the context is no longer active, this
// most likely is a database connection error.
if h.ctx.Err() == nil {
h.logger.Error(h.ctx, "failed to send coordinator delete", slog.Error(err))
}
return
}
h.logger.Debug(h.ctx, "deleted coordinator")
Expand Down