Skip to content

chore(scripts): fix stable release promote script #13204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 17, 2024
Merged

chore(scripts): fix stable release promote script #13204

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb9f2d1
chore(scripts): fix stable release promote script
mafredri May 7, 2024
daf03f8
set gh token outside workspace if gh is logged in
mafredri May 8, 2024
9417866
expand use-cases in `gh_auth`
mafredri May 8, 2024
a3b254d
redri
mafredri May 8, 2024
7573dfc
s/authenticate //
mafredri May 8, 2024
e7276be
Merge branch 'main' into mafredri/chore-scripts-fix-release-promote-env
mafredri May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
redri
  • Loading branch information
@mafredri
mafredri committed May 8, 2024
commit a3b254d3c446a6ff579285ec1c22b6e05f58cabd
2 changes: 1 addition & 1 deletion scripts/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ gh_auth() {
export GITHUB_TOKEN=${GH_TOKEN}
elif [[ ${CODER:-} == true ]]; then
if ! output=$(coder external-auth access-token github 2>&1); then
# TODO(maf): We could allow checking `gh auth token` here.
# TODO(mafredri): We could allow checking `gh auth token` here.
log "${output}"
error "Could not authenticate with GitHub using Coder external auth."
else
Expand Down