Skip to content

fix(site): fix floating number on duration fields #13209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 17, 2024
Merged

fix(site): fix floating number on duration fields #13209

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6d359fd
Add DurationField component
BrunoQuaresma May 8, 2024
5ac0602
Add empty story
BrunoQuaresma May 8, 2024
95e4f44
Avoid negative values
BrunoQuaresma May 8, 2024
4a48102
Use duration field time_til_dormant_ms
BrunoQuaresma May 9, 2024
09ddb8f
Fix parent updates
BrunoQuaresma May 9, 2024
3427160
Fix helper text
BrunoQuaresma May 9, 2024
eef159c
Support errors
BrunoQuaresma May 9, 2024
b3042c6
Use valueMs to make the value is in miliseconds
BrunoQuaresma May 10, 2024
e6101cf
Replace useState by useReducer
BrunoQuaresma May 10, 2024
c82fc8f
Add 10 to base int
BrunoQuaresma May 10, 2024
1b77488
Merge branch 'main' of https://github.com/coder/coder into bq/fix-flo…
BrunoQuaresma May 13, 2024
9036465
Use a number mask
BrunoQuaresma May 13, 2024
cac3a89
Make number input full width
BrunoQuaresma May 13, 2024
d89ec94
Add duration field to auto deletion
BrunoQuaresma May 13, 2024
0a93c9f
Apply duration field to failure clean up
BrunoQuaresma May 13, 2024
5a35e1a
Merge branch 'main' of https://github.com/coder/coder into bq/fix-flo…
BrunoQuaresma May 17, 2024
45a5eb5
Add extra tests to storybook
BrunoQuaresma May 17, 2024
a6ff426
Fix tests
BrunoQuaresma May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make number input full width
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 13, 2024
commit cac3a890f4ea5611a48d51dd2fa7212e3d6f16e4
2 changes: 1 addition & 1 deletion site/src/components/DurationField/DurationField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const DurationField: FC<DurationFieldProps> = (props) => {
>
<TextField
{...textFieldProps}
css={{ maxWidth: 160 }}
fullWidth
value={state.durationFieldValue}
onChange={(e) => {
const durationFieldValue = intMask(e.currentTarget.value);
Expand Down