Skip to content

chore: prevent commit signing in tests #13222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2024
Merged

chore: prevent commit signing in tests #13222

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1e7763
Do not attempt to sign commits in tests
dannykopping May 10, 2024
02a2e8a
Use GIT_CONFIG_GLOBAL=/dev/null and GIT_CONFIG_SYSTEM=/dev/null instead
dannykopping May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not attempt to sign commits in tests 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed May 10, 2024
commit e1e7763c822120a65a0cbb81fa14041bd61f5be1
14 changes: 7 additions & 7 deletions cli/dotfiles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func TestDotfiles(t *testing.T) {
err = c.Run()
require.NoError(t, err)

c = exec.Command("git", "commit", "-m", `"add .bashrc"`)
c = exec.Command("git", "commit", "-m", `"add .bashrc"`, `--no-gpg-sign`)
c.Dir = testRepo
out, err := c.CombinedOutput()
require.NoError(t, err, string(out))
Expand All @@ -64,7 +64,7 @@ func TestDotfiles(t *testing.T) {
err = c.Run()
require.NoError(t, err)

c = exec.Command("git", "commit", "-m", `"add .bashrc"`)
c = exec.Command("git", "commit", "-m", `"add .bashrc"`, `--no-gpg-sign`)
c.Dir = testRepo
out, err := c.CombinedOutput()
require.NoError(t, err, string(out))
Expand Down Expand Up @@ -95,7 +95,7 @@ func TestDotfiles(t *testing.T) {
err = c.Run()
require.NoError(t, err)

c = exec.Command("git", "commit", "-m", `"add .bashrc"`)
c = exec.Command("git", "commit", "-m", `"add .bashrc"`, `--no-gpg-sign`)
c.Dir = testRepo
out, err := c.CombinedOutput()
require.NoError(t, err, string(out))
Expand Down Expand Up @@ -129,7 +129,7 @@ func TestDotfiles(t *testing.T) {
err = c.Run()
require.NoError(t, err)

c = exec.Command("git", "commit", "-m", `"add install.sh"`)
c = exec.Command("git", "commit", "-m", `"add install.sh"`, `--no-gpg-sign`)
c.Dir = testRepo
err = c.Run()
require.NoError(t, err)
Expand All @@ -151,7 +151,7 @@ func TestDotfiles(t *testing.T) {
testRepo := testGitRepo(t, root)

// We need an initial commit to start the `main` branch
c := exec.Command("git", "commit", "--allow-empty", "-m", `"initial commit"`)
c := exec.Command("git", "commit", "--allow-empty", "-m", `"initial commit"`, `--no-gpg-sign`)
c.Dir = testRepo
err := c.Run()
require.NoError(t, err)
Expand All @@ -170,7 +170,7 @@ func TestDotfiles(t *testing.T) {
err = c.Run()
require.NoError(t, err)

c = exec.Command("git", "commit", "-m", `"add install.sh"`)
c = exec.Command("git", "commit", "-m", `"add install.sh"`, `--no-gpg-sign`)
c.Dir = testRepo
err = c.Run()
require.NoError(t, err)
Expand Down Expand Up @@ -207,7 +207,7 @@ func TestDotfiles(t *testing.T) {
err = c.Run()
require.NoError(t, err)

c = exec.Command("git", "commit", "-m", `"add .bashrc"`)
c = exec.Command("git", "commit", "-m", `"add .bashrc"`, `--no-gpg-sign`)
c.Dir = testRepo
out, err := c.CombinedOutput()
require.NoError(t, err, string(out))
Expand Down
Loading