Skip to content

fix(site): fix group badge visual #13263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2024
Merged

fix(site): fix group badge visual #13263

merged 3 commits into from
May 14, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Just used a button to simplify styling.

Closes #13069

@BrunoQuaresma BrunoQuaresma requested a review from Parkreiner May 13, 2024 17:10
@BrunoQuaresma BrunoQuaresma self-assigned this May 13, 2024
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully clear on what the original issue has highlighting – I'm guessing that the interactive area for the Groups content was really small, and wasn't filling out the entire table cell. Is that basically right?

Just want to make sure before I give the approval

@BrunoQuaresma
Copy link
Collaborator Author

Basically in the light mode, there is a box shadow around the button that is strange.

@BrunoQuaresma BrunoQuaresma requested a review from Parkreiner May 13, 2024 19:03
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me!

@BrunoQuaresma BrunoQuaresma merged commit f149279 into main May 14, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-group-badge branch May 14, 2024 16:52
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users page > groups bubbles have insufficient padding
2 participants