chore: expose all organization ids from AuthContext #13268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
May 13, 2024
Comment on lines
+46
to
+50
| const [activeOrganizationId, setActiveOrganizationId] = useState(() => | ||
| lastUsedOrganizationId && organizationIds.includes(lastUsedOrganizationId) | ||
| ? lastUsedOrganizationId | ||
| : organizationIds[0], | ||
| ); |
There was a problem hiding this comment.
Talked to @aslilac, we are not going to introduce the concept of "Default Org" to the FE. It is a stop gap on the backend to accommodate features like group sync, role sync, SCIM, etc. Those features need to be upgraded to not rely on default org.
If a deployment exists with more than 1 org, this is no more broken than it currently is today.
| if (!organizationIds.includes(id)) { | ||
| throw new ReferenceError("Invalid organization ID"); | ||
| } | ||
| localStorage.setItem(`user:${user.id}.lastUsedOrganizationId`, id); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important bit of this change is in AuthContext.tsx and DashboardProvider.tsx:
AuthContextnow exposes anorganizationIdsproperty, which is a list, rather than theorganizationIdproperty, which was a single ID.DashboardContextis now responsible for managing the state around which organization should be "active" in the app.The rest is just "to whom it may concern" updates to accommodate those changes.
Also, some of these usages of
organizationIdare almost certainly incorrect, but I'd rather audit all of that in a separate PR.