Skip to content

fix(docs): correct sharable port's interaction with coder_app #13285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

stirby
Copy link
Collaborator

@stirby stirby commented May 15, 2024

Was

This can also be used to change the sharing level of coder_apps by entering
their port number in the shared ports UI. The share attribute of coder_apps
defined using the terraform provider can be overridden by sharing the port. The
sharing level is limited by the maximum level enforced by the template in
enterprise deployments, and not restricted in OSS deployments.

Now

The sharing level is limited by the maximum level enforced in the template
settings in enterprise deployments, and not restricted in OSS deployments.

This can also be used to change the sharing level of coder_apps by entering
their port number in the sharable ports UI. The share attribute on coder_app
resource uses a different method of authentication and is not impacted by the
template's maximum sharing level
, nor the level of a shared port that points
to the app.

@stirby stirby requested a review from f0ssel May 15, 2024 19:28
@stirby stirby requested review from maeanes and removed request for maeanes May 15, 2024 19:29
@stirby stirby changed the title fix(docs): Correct sharable port's interaction with coder_app fix(docs): correct sharable port's interaction with coder_app May 15, 2024
@stirby stirby merged commit 114fb31 into main May 15, 2024
29 checks passed
@stirby stirby deleted the docs-fix-sharable-ports branch May 15, 2024 19:40
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants