Skip to content

feat(coderd): add endpoints for editing and deleting organizations #13287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
May 21, 2024
Merged

feat(coderd): add endpoints for editing and deleting organizations #13287

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
7d40b8b
patchOrganization
aslilac May 15, 2024
f16e0f6
Merge branch 'main' into edit-and-delete-orgs
aslilac May 15, 2024
06378e4
dbauthz and dbmem impls
aslilac May 15, 2024
10224ad
gen
aslilac May 15, 2024
265a895
🪓
aslilac May 16, 2024
dea7c0a
fix message
aslilac May 16, 2024
f641a49
no body
aslilac May 16, 2024
0ea9a12
it's fine now I guess
aslilac May 16, 2024
e6a0ec0
codersdk client functions, tests
aslilac May 16, 2024
72ebaee
something
aslilac May 16, 2024
8902a85
🧪
aslilac May 16, 2024
8ec3904
fix `@Param` annotations
aslilac May 16, 2024
ee44145
match query
aslilac May 16, 2024
f30665c
only validate name if it's different
aslilac May 16, 2024
8342b26
⚗️🧹
aslilac May 16, 2024
dda30ec
>:(
aslilac May 16, 2024
514fcdf
small refactors
aslilac May 17, 2024
4ee37e2
named sql args
aslilac May 17, 2024
7f3602e
Merge branch 'main' into edit-and-delete-orgs
aslilac May 17, 2024
f34b1eb
rework update error handling
aslilac May 17, 2024
2125e2d
🧹
aslilac May 17, 2024
6686bb3
🧹
aslilac May 17, 2024
68bd28d
Merge branch 'main' into edit-and-delete-orgs
aslilac May 17, 2024
9c769f8
enforce unique_organizations_name constraint in dbmem
aslilac May 17, 2024
94484a0
refactor unique constraint error mocking a little
aslilac May 17, 2024
b1bfba6
wow
aslilac May 17, 2024
ef5d804
Merge branch 'main' into edit-and-delete-orgs
aslilac May 21, 2024
fe5e3ce
Merge branch 'main' into edit-and-delete-orgs
aslilac May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🧪
  • Loading branch information
@aslilac
aslilac committed May 16, 2024
commit 8902a857d1aea447cb5161acead4015b239f7dd3
4 changes: 2 additions & 2 deletions coderd/database/dbauthz/dbauthz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ func (s *MethodTestSuite) TestOrganization() {
check.Args(database.UpdateOrganizationParams{
ID: o.ID,
Name: "something-different",
}).Asserts(rbac.ResourceOrganization, policy.ActionUpdate)
}).Asserts(o, policy.ActionUpdate)
}))
s.Run("DeleteOrganization", s.Subtest(func(db database.Store, check *expects) {
ctx := testutil.Context(s.T(), testutil.WaitShort)
Expand All @@ -660,7 +660,7 @@ func (s *MethodTestSuite) TestOrganization() {
require.NoError(s.T(), err)
check.Args(
o.ID,
).Asserts(rbac.ResourceOrganization, policy.ActionDelete)
).Asserts(o, policy.ActionDelete)
}))
s.Run("UpdateMemberRoles", s.Subtest(func(db database.Store, check *expects) {
o := dbgen.Organization(s.T(), db, database.Organization{})
Expand Down