Skip to content

feat(site): add basic organization management ui #13288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 17, 2024
Merged

feat(site): add basic organization management ui #13288

merged 24 commits into from
Jun 17, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented May 15, 2024 •
edited
Loading

Screenshot 2024-06-13 at 10 42 49 AM

It's not completely fleshed out, but it's behind an experiment and gives us something to build on.

@github-actions github-actions bot added the stale This issue is like stale bread. label May 24, 2024
@github-actions github-actions bot closed this May 28, 2024
@aslilac aslilac reopened this Jun 3, 2024
@aslilac aslilac force-pushed the org-management-ui branch from 3e1720c to f36f106 Compare June 3, 2024 21:16
@github-actions github-actions bot removed the stale This issue is like stale bread. label Jun 4, 2024
@aslilac aslilac changed the title feat(site): wip org management ui feat(site): basic org management ui Jun 11, 2024
@aslilac aslilac changed the title feat(site): basic org management ui feat(site): add basic organization management ui Jun 11, 2024
@aslilac aslilac requested a review from BrunoQuaresma June 13, 2024 16:44
@aslilac aslilac marked this pull request as ready for review June 13, 2024 16:44
BrunoQuaresma
BrunoQuaresma reviewed Jun 14, 2024
View reviewed changes
site/src/pages/OrganizationSettingsPage/OrganizationSettingsPage.tsx
export default OrganizationSettingsPage;

const styles = {
dangerButton: (theme) => ({
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma Jun 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the current style for danger buttons is not good enough, I think we should apply the changes in the mui styles to make it consistent across the UI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from the delete dialog. This is gonna get reworked and removed later.

BrunoQuaresma
BrunoQuaresma reviewed Jun 14, 2024
View reviewed changes
site/src/pages/OrganizationSettingsPage/Sidebar.tsx
href: string;
}

export const SidebarNavItem: FC<SidebarNavItemProps> = ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a set of common components to build a sidebar. If not, we probably should make them to keep it consistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do, but the styling of the sidebar in this view needs to be quite different from our existing sidebars. we can see if there's a nice way to unify them later. I tried using them initially, but it's a lot easier to iterate this way for now.

BrunoQuaresma
BrunoQuaresma reviewed Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments and I'm missing tests for the new additions.

@BrunoQuaresma
Copy link
Collaborator

A few UX findings:

  • I would expect the sidebar to use the org display name if it is available
  • I would expect to see a success notification when saving the settings

@aslilac
Copy link
Member Author

aslilac commented Jun 14, 2024

I would expect the sidebar to use the org display name if it is available

It already does.

@aslilac aslilac requested a review from BrunoQuaresma June 14, 2024 22:00
@BrunoQuaresma
Copy link
Collaborator

I was able to create an org and I'm leaving a few considerations even knowing some of them may be out of the scope of this PR.

The create org form is below the fold
When I tried the first time, I didn't see the form because I didn't notice it was below the fold. Maybe we could add a "Create organization" in the sidebar that can open a modal with the form.

Screenshot 2024-06-17 at 10 50 55

Validation

  • The validation is not clear about the error
  • I'm missing a space from the alert and form
  • When focusing on the alert, I have to scroll down to see the form again
  • We should have a help text for the name saying it does not accept special characters
Screenshot 2024-06-17 at 10 50 47

Create org
We can display a success alert and reset the scroll to the top.

Delete org

  • We can display an icon button with a "trash" icon on the right of the name or below.
  • Show a confirmation dialog.

@aslilac
Copy link
Member Author

aslilac commented Jun 17, 2024

Creating and deleting orgs is going to get entirely redone.

@aslilac aslilac merged commit 8c1bd32 into main Jun 17, 2024
30 checks passed
@aslilac aslilac deleted the org-management-ui branch June 17, 2024 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @BrunoQuaresma