Skip to content

fix: Remove "CODER_URL" and "CODER_TOKEN" #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2022
Merged

fix: Remove "CODER_URL" and "CODER_TOKEN" #1330

merged 1 commit into from
May 6, 2022

Conversation

kylecarbs
Copy link
Member

These aren't being used, so it's best to remove for now.
It caused issues with dogfooding from v1 too!

@kylecarbs
fix: Remove "CODER_URL" and "CODER_TOKEN"
c56004d 
These aren't being used, so it's best to remove for now.
It caused issues with dogfooding from v1 too!
@kylecarbs kylecarbs requested review from spikecurtis and f0ssel May 6, 2022 18:37
@kylecarbs kylecarbs self-assigned this May 6, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) May 6, 2022 18:37
@codecov
Copy link

codecov bot commented May 6, 2022 •
edited
Loading

Codecov Report

Merging #1330 (c56004d) into main (cf5aca7) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1330      +/-   ##
==========================================
+ Coverage   65.96%   66.25%   +0.28%     
==========================================
  Files         278      280       +2     
  Lines       18348    18369      +21     
  Branches      235      235              
==========================================
+ Hits        12104    12171      +67     
+ Misses       4966     4939      -27     
+ Partials     1278     1259      -19
Flag Coverage Δ
unittest-go-macos-latest 53.60% <100.00%> (?)
unittest-go-postgres- 65.03% <100.00%> (-0.07%) ⬇️
unittest-go-ubuntu-latest 56.06% <100.00%> (?)
unittest-js 73.67% <ø> (ø)
Impacted Files Coverage Δ
cli/root.go 79.13% <100.00%> (ø)
coderd/workspaceagents.go 56.04% <0.00%> (-0.94%) ⬇️
agent/agent.go 64.04% <0.00%> (-0.62%) ⬇️
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
provisionerd/provisionerd.go 75.90% <0.00%> (+0.26%) ⬆️
coderd/users.go 61.36% <0.00%> (+0.43%) ⬆️
peer/channel.go 85.96% <0.00%> (+1.75%) ⬆️
cli/cliui/provisionerjob.go 78.57% <0.00%> (+2.14%) ⬆️
coderd/templateversions.go 58.99% <0.00%> (+2.15%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5aca7...c56004d. Read the comment docs.

@kylecarbs kylecarbs merged commit 97ee560 into main May 6, 2022
@kylecarbs kylecarbs deleted the rmenv branch May 6, 2022 18:46
@f0ssel f0ssel mentioned this pull request May 6, 2022
Closed
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Remove "CODER_URL" and "CODER_TOKEN" (#1330)
c5d349f 
These aren't being used, so it's best to remove for now.
It caused issues with dogfooding from v1 too!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0ssel f0ssel f0ssel approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @f0ssel @misskniss