ci: fix test-migrations target when main branch is not present locally #13306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
May 17, 2024
| @@ -797,8 +797,11 @@ test-postgres: test-postgres-docker | |||
| test-migrations: test-postgres-docker | |||
| echo "--- test migrations" | |||
| set -euo pipefail | |||
| COMMIT_FROM=$(shell git rev-parse --short HEAD) | |||
| COMMIT_TO=$(shell git rev-parse --short main) | |||
| COMMIT_FROM=$(shell git log -1 --format='%h' HEAD) | |||
There was a problem hiding this comment.
Why short-form, btw? I guess it's more human friendly, but the long-form is more robust.
There was a problem hiding this comment.
I was initially worried about exceeding the maximum name length of a database name, but it looks like we're under the 63 byte limit even with the long identifier.
| COMMIT_FROM=$(shell git rev-parse --short HEAD) | ||
| COMMIT_TO=$(shell git rev-parse --short main) | ||
| COMMIT_FROM=$(shell git log -1 --format='%h' HEAD) | ||
| echo "COMMIT_FROM=$${COMMIT_FROM}" |
There was a problem hiding this comment.
Pro-tip: declare is pretty nice (declare -p COMMIT_FROM COMMIT_TO. Not necessarily for here, but future reference.
I think it's way clearer: I suppose we could also just read |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/coder/coder/actions/runs/8989166240/job/24691648877 appears to have failed because the local reference to
mainwas not present. Additionally,git rev-parseproduces a slightly cryptic error message when the ref specified does not exit.To validate this, I deleted the
mainbranch locally and observed the same error before the change. After the change, this works as intended.