chore: add refresh token and error to user's external auth page #13380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea, but using the refresh icon directly on top of the provider icon does not have enough contrast so you can wrap it with a circular badge like the following image. You can look at the MUI Badge docs , and how they can be styled, and used with other elements. As a secondary option, that does not look that good compared with the first option, you can use pills close to the action button.
|
|
I really like this. The error and the refresh icon are actually not related. I'll give it a go at replicating that picture 👍 |
BrunoQuaresma
approved these changes
May 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13381
What this does
We have 2 fields,
has_refresh_tokenandvalidate_erroron external authentication links that are not being exposed to the UI. Multiple users have asked how to determine if refresh tokens are being returned from the IDP.This allows more user self serve for debugging.
has_refresh_tokeniconA little "refresh" icon shown as an avatar badge with tooltip if the link has a refresh token.
Validate error
Displays the error below the link. (Ignore my typo of "Refresh")
Future work
Can probably be styled better in the future.