Skip to content

chore: skip Azure TestExpiresSoon #13385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024
Merged

chore: skip Azure TestExpiresSoon #13385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: skip Azure TestExpiresSoon 
Adds some context to the test skip so it can be removed or enabled in the future.
  • Loading branch information
@kylecarbs
kylecarbs committed May 28, 2024
commit cd8e3e7dc8645fd625b3b96e5d85e7328d6f6c1f
4 changes: 4 additions & 0 deletions coderd/azureidentity/azureidentity_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ func TestValidate(t *testing.T) {

func TestExpiresSoon(t *testing.T) {
t.Parallel()
// TODO (@kylecarbs): It's unknown why Microsoft does not have new certificates live...
// The certificate is automatically fetched if it's not found in our database,
// so in a worst-case scenario expired certificates will only impact 100% airgapped users.
t.Skip()
const threshold = 1

for _, c := range azureidentity.Certificates {
Expand Down