Skip to content

chore: remove stats batcher and workspace usage tracker #13393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

chore: remove stats batcher and workspace usage tracker #13393

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0400a53
chore: remove stats batcher
f0ssel May 29, 2024
ca851ba
fix tests
f0ssel May 29, 2024
cd70514
system call
f0ssel May 29, 2024
e7b1de8
fix deps
f0ssel May 29, 2024
188103c
remove workspace usage tracker
f0ssel May 30, 2024
59048fd
fix port forward tests
f0ssel May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
system call
  • Loading branch information
@f0ssel
f0ssel committed May 29, 2024
commit cd70514c0a60c2940c279061dfdab436f2d8b159
4 changes: 3 additions & 1 deletion coderd/workspacestats/reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (

agentproto "github.com/coder/coder/v2/agent/proto"
"github.com/coder/coder/v2/coderd/database"
"github.com/coder/coder/v2/coderd/database/dbauthz"
"github.com/coder/coder/v2/coderd/database/dbtime"
"github.com/coder/coder/v2/coderd/database/pubsub"
"github.com/coder/coder/v2/coderd/prometheusmetrics"
Expand Down Expand Up @@ -175,7 +176,8 @@ func (r *Reporter) ReportAgentStats(ctx context.Context, now time.Time, workspac
ConnectionMedianLatencyMS: []float64{stats.ConnectionMedianLatencyMs},
}
elapsed := time.Since(start)
err = r.opts.Database.InsertWorkspaceAgentStats(ctx, params)
// nolint: gocritic // system function
err = r.opts.Database.InsertWorkspaceAgentStats(dbauthz.AsSystemRestricted(ctx), params)
if err != nil {
if database.IsQueryCanceledError(err) {
r.opts.Logger.Debug(ctx, "query canceled, skipping insert of workspace agent stats", slog.F("elapsed", elapsed))
Expand Down