Skip to content

chore: remove git pinning in base image #13414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

dannykopping
Copy link
Contributor

Alpine 3.20 includes 2.45.1 by default: https://git.alpinelinux.org/aports/tree/main/git/APKBUILD?h=3.20-stable#n56

Follow-up from #13411 (comment)

@coadler heads up, this removes the pinning you needed to add in #13299.

Alpine 3.20 includes 2.45.1 by default: https://git.alpinelinux.org/aports/tree/main/git/APKBUILD?h=3.20-stable#n56

Follow-up from coder#13411 (comment)

Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Contributor

@coadler coadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@dannykopping
Copy link
Contributor Author

I believe docker-base is failing because my PR is coming from a fork.
I think we're ok to merge.
WDYT @coadler?

I'm happy to recreate with a branch within coder/coder if necessary.

@coadler
Copy link
Contributor

coadler commented May 30, 2024

yeah, i think it's fine to ship

@dannykopping dannykopping merged commit 7569ccc into coder:main May 30, 2024
25 of 26 checks passed
@dannykopping dannykopping deleted the dk/fix-alpine-build branch May 30, 2024 13:58
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants