Skip to content

chore(scripts): fix expression interpreted as exit code on some Bash versions #13417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

chore(scripts): fix expression interpreted as exit code on some Bash versions #13417

merged 1 commit into from
May 30, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented May 30, 2024 •
edited
Loading

Changes ((i--)) -> i=$((i - 1)).

@mafredri mafredri self-assigned this May 30, 2024
@mafredri mafredri requested a review from stirby May 30, 2024 17:00
@mafredri mafredri added the hotfix PRs only. Harmless small change. Only humans may set this. label May 30, 2024
cdr-bot[bot]
cdr-bot bot approved these changes May 30, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mafredri mafredri enabled auto-merge (squash) May 30, 2024 17:01
stirby
stirby approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mafredri mafredri merged commit 4758952 into main May 30, 2024
34 checks passed
@mafredri mafredri deleted the mafredri/chore-fix-expression-in-commit-metadata-script branch May 30, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stirby stirby stirby approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mafredri mafredri

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @stirby