chore: move Batcher and Tracker to workspacestats #13418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
May 30, 2024
coderd/workspacestats/batcher.go
Outdated
Comment on lines
27
to
29
| type StatsBatcher interface { | ||
| Add(now time.Time, agentID uuid.UUID, templateID uuid.UUID, userID uuid.UUID, workspaceID uuid.UUID, st *agentproto.Stats) error | ||
| } |
There was a problem hiding this comment.
Why do we have this interface and the batcher?
There was a problem hiding this comment.
There's a test implementation at https://github.com/coder/coder/blob/f0ssel/move-batchers/coderd/agentapi/stats_test.go#L30. That being said, there's a duplicate definition of this interface at https://github.com/coder/coder/blob/f0ssel/move-batchers/coderd/agentapi/stats.go#L19 that can be removed.
johnstcn
approved these changes
May 31, 2024
Comment on lines
+871
to
+874
| batcher, closeBatcher, err := workspacestats.NewBatcher(ctx, | ||
| workspacestats.BatcherWithLogger(options.Logger.Named("batchstats")), | ||
| workspacestats.BatcherWithStore(options.Database), |
There was a problem hiding this comment.
I'm not particularly married to the functional opts here if you want to use a more conventional opts struct instead or just straight-up function args.
e2b56ec to
9295149
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
batchstats.Batcherandworkspaceusage.Trackerinto theworkspacestatspackage to keep all updates tolast_used_atinside the same package. There are no functional changes in this PR.