chore: rename notification banners to announcement banners #13419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stirby
approved these changes
May 30, 2024
|
Do you see any issue with leaving the internal symbols as NotificationBanner? |
I kind of assumed that we'd already published a release with this feature, which would make renaming stuff in the code a breaking change, but I just double checked and realized that we haven't. It'd actually be a good idea to rename it more thoroughly, I just didn't realize I could. 😄 |
|
Ahh gotcha, appreciate you playing it safe 😁. The code freeze is tomorrow but I can cherry pick this in if you need time for the rename. 👍 |
|
I think it should be ready to go! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.