Skip to content

fix!: remove failing_sections from healthcheck #13426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

kylecarbs
Copy link
Member

Closes #10854.

@kylecarbs kylecarbs requested a review from johnstcn May 31, 2024 14:44
@kylecarbs kylecarbs self-assigned this May 31, 2024
@kylecarbs kylecarbs force-pushed the rmfailingsections branch from ed1d250 to 160ec89 Compare May 31, 2024 14:46
@kylecarbs kylecarbs enabled auto-merge (squash) May 31, 2024 14:46
@github-actions github-actions bot added the stale This issue is like stale bread. label Jun 8, 2024
@github-actions github-actions bot closed this Jun 12, 2024
auto-merge was automatically disabled June 12, 2024 00:04

Pull request was closed

@johnstcn johnstcn reopened this Jun 12, 2024
@johnstcn johnstcn removed the stale This issue is like stale bread. label Jun 12, 2024
@coadler
Copy link
Contributor

coadler commented Jun 13, 2024

Is this technically a breaking change?

@johnstcn
Copy link
Member

Is this technically a breaking change?

Yeah I guess it would be, strictly speaking.

@johnstcn johnstcn changed the title chore: remove failing_sections from healthcheck fix!: remove failing_sections from healthcheck Jun 14, 2024
@github-actions github-actions bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Jun 14, 2024
@kylecarbs kylecarbs merged commit 54e8f30 into main Jun 21, 2024
59 of 63 checks passed
@kylecarbs kylecarbs deleted the rmfailingsections branch June 21, 2024 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove FailingSections from HealthCheckReport
3 participants