Skip to content

chore: external auth validate response "Forbidden" should return invalid, not an error #13446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2024
Merged

chore: external auth validate response "Forbidden" should return invalid, not an error #13446

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9995a0c
chore: add unit test to delete workspace from suspended user
Emyrk Jun 3, 2024
36340e6
chore: account for forbidden as well as unauthorized response codes
Emyrk Jun 3, 2024
4a87dc0
linting
Emyrk Jun 3, 2024
e31dd45
fixup test status code
Emyrk Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup test status code
  • Loading branch information
@Emyrk
Emyrk committed Jun 3, 2024
commit e31dd4543a57d9a04ad97a501d11450df9be863d
4 changes: 2 additions & 2 deletions coderd/externalauth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ func TestExternalAuthCallback(t *testing.T) {
// If the validation URL gives a non-OK status code, this
// should be treated as an internal server error.
srv.Config.Handler = http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusForbidden)
w.WriteHeader(http.StatusBadRequest)
w.Write([]byte("Something went wrong!"))
})
_, err = agentClient.ExternalAuth(ctx, agentsdk.ExternalAuthRequest{
Expand All @@ -565,7 +565,7 @@ func TestExternalAuthCallback(t *testing.T) {
var apiError *codersdk.Error
require.ErrorAs(t, err, &apiError)
require.Equal(t, http.StatusInternalServerError, apiError.StatusCode())
require.Equal(t, "validate external auth token: status 403: body: Something went wrong!", apiError.Detail)
require.Equal(t, "validate external auth token: status 400: body: Something went wrong!", apiError.Detail)
})

t.Run("ExpiredNoRefresh", func(t *testing.T) {
Expand Down
Loading