Skip to content

fix(cli): inherit provisioner tags from last template version #13462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 4, 2024
Merged

fix(cli): inherit provisioner tags from last template version #13462

merged 7 commits into from
Jun 4, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jun 4, 2024

Fixes: #13131

@mtojek mtojek self-assigned this Jun 4, 2024
@mtojek mtojek requested a review from johnstcn June 4, 2024 10:51
@mtojek mtojek marked this pull request as ready for review June 4, 2024 10:51
johnstcn
johnstcn approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits and suggestions. I don't need to review again. 👍

@mtojek mtojek enabled auto-merge (squash) June 4, 2024 11:53
@mtojek mtojek merged commit cd32c42 into main Jun 4, 2024
27 checks passed
@mtojek mtojek deleted the 13131-tags branch June 4, 2024 11:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali left review comments

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

updating a template via CLI that has tags set through template editor strips all provisioner tags
3 participants
@mtojek @johnstcn @matifali