Skip to content

chore: add example test case for clock package #13465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jun 4, 2024

Adds an example test case which covers how to use traps and TickerFunc.

Copy link
Contributor Author

spikecurtis commented Jun 4, 2024

@spikecurtis spikecurtis requested a review from johnstcn June 4, 2024 13:02
@spikecurtis spikecurtis marked this pull request as ready for review June 4, 2024 13:03
@spikecurtis spikecurtis force-pushed the spike/clock-testing-example branch 2 times, most recently from 850d275 to 6b73c5c Compare June 4, 2024 13:06
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest modifying to match https://pkg.go.dev/testing#hdr-Examples but I'm also OK with this format. 👍 I don't need to review again.

@spikecurtis spikecurtis force-pushed the spike/clock-testing-explicit-wait branch from 1f3c4aa to b55fc1a Compare June 5, 2024 06:14
@spikecurtis spikecurtis force-pushed the spike/clock-testing-example branch from 6b73c5c to 49c251a Compare June 5, 2024 06:15
@spikecurtis spikecurtis force-pushed the spike/clock-testing-explicit-wait branch from b55fc1a to 35daa55 Compare June 5, 2024 09:56
@spikecurtis spikecurtis force-pushed the spike/clock-testing-example branch from 49c251a to ddbd5b9 Compare June 5, 2024 09:56
@spikecurtis spikecurtis force-pushed the spike/clock-testing-explicit-wait branch from 35daa55 to 6e5decd Compare June 5, 2024 10:01
@spikecurtis spikecurtis force-pushed the spike/clock-testing-example branch from ddbd5b9 to 9492dac Compare June 5, 2024 10:01
Base automatically changed from spike/clock-testing-explicit-wait to main June 5, 2024 11:37
@spikecurtis spikecurtis force-pushed the spike/clock-testing-example branch from 9492dac to 087459c Compare June 5, 2024 11:37
Copy link
Contributor Author

spikecurtis commented Jun 5, 2024

Merge activity

  • Jun 5, 7:38 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 5, 7:49 AM EDT: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis merged commit ffcfbb6 into main Jun 5, 2024
27 checks passed
@spikecurtis spikecurtis deleted the spike/clock-testing-example branch June 5, 2024 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants