Skip to content

ci: migrate to depot.dev runners #13467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 25, 2024
Merged

ci: migrate to depot.dev runners #13467

merged 14 commits into from
Jun 25, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Jun 4, 2024 •
edited
Loading

Saves cost while providing faster ci jobs.

I may have missed a few buildjet runners.
We can test it for a few days before canceling buildjet subscription.

@matifali matifali closed this Jun 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
@matifali matifali reopened this Jun 21, 2024
@matifali matifali closed this Jun 21, 2024
@matifali matifali reopened this Jun 22, 2024
@coder coder unlocked this conversation Jun 22, 2024
@matifali matifali marked this pull request as ready for review June 22, 2024 18:57
@matifali matifali requested review from ammario and deansheather June 22, 2024 18:57
@matifali matifali changed the title ci: migrate to depot runners ci: migrate to depot.dev runners Jun 22, 2024
@matifali matifali mentioned this pull request Jun 23, 2024
Closed
deansheather
deansheather reviewed Jun 23, 2024
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

I may have missed a few buildjet runners.

This needs to be verified before merge though

@matifali
Copy link
Member Author

Holding for now as #13636 is flaking constantly on this PR.

@matifali
Copy link
Member Author

Hi @ammario, can you or someone look at why test-go and test-go-pg are constantly failing only on depot.dev runners? We need to be sure if it's a flake or depot.dev issue. I've already raised this with support.

@ammario
Copy link
Member

ammario commented Jun 24, 2024

I can't look into this right now. While they're failing can we restrict to only certain branches?

@matifali
Copy link
Member Author

There is no haste to migrate and @johnstcn and @goller are looking into it.
Meanwhile we can do a partial migration where these two jobs run on existing runners.

@johnstcn
Copy link
Member

@matifali please rebase on main; I've merged #13636.

deansheather
deansheather approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we have any signs of issues though and we can't immediately figure out the cause, we can revert the PR to unblock

@matifali
Copy link
Member Author

matifali commented Jun 25, 2024 •
edited
Loading

@deansheather I have also sent you an invite for depot.dev organization.

@matifali matifali merged commit 1369002 into main Jun 25, 2024
30 checks passed
@matifali matifali deleted the depot-runners branch June 25, 2024 06:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@ammario ammario ammario approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matifali @ammario @johnstcn @deansheather