chore: add Now, Since, AfterFunc to clock; use clock for configmaps test #13476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
ddbd5b9 to
9492dac
Compare
ec72835 to
1da8c45
Compare
johnstcn
approved these changes
Jun 5, 2024
Comment on lines
-633
to
-639
| // Before we update the clock again, we need to be sure the timeout has | ||
| // completed running. To do that, we check the new lastHandshake has been set | ||
| require.Eventually(t, func() bool { | ||
| uut.L.Lock() | ||
| defer uut.L.Unlock() | ||
| return uut.peers[p1ID].lastHandshake == lh | ||
| }, testutil.WaitShort, testutil.IntervalFast) |
There was a problem hiding this comment.
Why do we no longer need this check?
There was a problem hiding this comment.
I'm glad you asked! One of the benefits of this library compared with benbjohnson/clock is that we can use Advance().MustWait() to wait for all the AfterFunc() functions to run. So, we don't need to use require.Eventually() and peer into the internal state in order to ensure the timeout has been processed.
9492dac to
087459c
Compare
Signed-off-by: Spike Curtis <spike@coder.com>
1da8c45 to
d5ad7ac
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Now(),Since(),AfterFunc()to clockUse
clockfor configmaps test