Skip to content

feat: add name field to setup screen + CLI #13491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

feat: add name field to setup screen + CLI #13491

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
22335c7
feat: add name field to setup screen
johnstcn Jun 6, 2024
64af358
remove autofocus from optional name field
johnstcn Jun 6, 2024
31313bc
make fmt
johnstcn Jun 7, 2024
2805571
fix typo in login args
johnstcn Jun 7, 2024
a62a8ee
fix ConvertUserRows
johnstcn Jun 7, 2024
ec1befd
reuse FirstUserParams in login_test
johnstcn Jun 7, 2024
e80f4c8
fix password reprompt test
johnstcn Jun 7, 2024
c3849be
add test to ensure name is optional
johnstcn Jun 7, 2024
7cf406d
update golden files
johnstcn Jun 7, 2024
ca2bafa
s/name/full_name
johnstcn Jun 14, 2024
3eadba7
ignore nestif linter complaint
johnstcn Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test to ensure name is optional
  • Loading branch information
@johnstcn
johnstcn committed Jun 7, 2024
commit c3849be7cbbe8413ed2bdbd71070c243f9345c9a
46 changes: 46 additions & 0 deletions cli/login_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,52 @@ func TestLogin(t *testing.T) {
assert.Equal(t, coderdtest.FirstUserParams.Email, me.Email)
})

t.Run("InitialUserTTYNameOptional", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
// The --force-tty flag is required on Windows, because the `isatty` library does not
// accurately detect Windows ptys when they are not attached to a process:
// https://github.com/mattn/go-isatty/issues/59
doneChan := make(chan struct{})
root, _ := clitest.New(t, "login", "--force-tty", client.URL.String())
pty := ptytest.New(t).Attach(root)
go func() {
defer close(doneChan)
err := root.Run()
assert.NoError(t, err)
}()

matches := []string{
"first user?", "yes",
"username", coderdtest.FirstUserParams.Username,
"name", "",
"email", coderdtest.FirstUserParams.Email,
"password", coderdtest.FirstUserParams.Password,
"password", coderdtest.FirstUserParams.Password, // confirm
"trial", "yes",
}
for i := 0; i < len(matches); i += 2 {
match := matches[i]
value := matches[i+1]
pty.ExpectMatch(match)
pty.WriteLine(value)
}
pty.ExpectMatch("Welcome to Coder")
<-doneChan
ctx := testutil.Context(t, testutil.WaitShort)
resp, err := client.LoginWithPassword(ctx, codersdk.LoginWithPasswordRequest{
Email: coderdtest.FirstUserParams.Email,
Password: coderdtest.FirstUserParams.Password,
})
require.NoError(t, err)
client.SetSessionToken(resp.SessionToken)
me, err := client.User(ctx, codersdk.Me)
require.NoError(t, err)
assert.Equal(t, coderdtest.FirstUserParams.Username, me.Username)
assert.Equal(t, coderdtest.FirstUserParams.Email, me.Email)
assert.Empty(t, me.Name)
})

t.Run("InitialUserTTYFlag", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t, nil)
Expand Down