Skip to content

chore(cli): address cli netcheck test flake #13492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2024
+48 −4
Merged

chore(cli): address cli netcheck test flake #13492

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fa3710
chore(cli): netcheck: remove check for healthy node report in test
johnstcn Jun 6, 2024
7c9d51a
fix(coderd/healthcheck/derphealth): do not override parent context de…
johnstcn Jun 6, 2024
62ce1c5
fixup! fix(coderd/healthcheck/derphealth): do not override parent con…
johnstcn Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fix(coderd/healthcheck/derphealth): do not override parent con… 
…text deadline
  • Loading branch information
@johnstcn
johnstcn committed Jun 6, 2024
commit 62ce1c5fd5f6ffb3a96c4ea5bc0fbed4928aec6d
4 changes: 1 addition & 3 deletions coderd/healthcheck/derphealth/derp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ func TestDERP(t *testing.T) {
report.Run(ctx, opts)

assert.False(t, report.Healthy)
if assert.NotNil(t, report.Error) {
assert.Contains(t, context.DeadlineExceeded, *report.Error)
}
assert.Nil(t, report.Error)
})

t.Run("HealthyWithNodeDegraded", func(t *testing.T) {
Expand Down