Skip to content

feat: block file transfers for security #13501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 10, 2024
Merged

feat: block file transfers for security #13501

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
94a4067
feat: block file transfers
mtojek Jun 7, 2024
9915cde
commands
mtojek Jun 7, 2024
abd97df
fix
mtojek Jun 7, 2024
00e0a8a
fix
mtojek Jun 7, 2024
6cec719
Merge branch 'main' into 13383-scp
mtojek Jun 7, 2024
fa0010d
Fix
mtojek Jun 7, 2024
dbaa763
fix
mtojek Jun 7, 2024
94926bd
fix
mtojek Jun 7, 2024
d92c070
fix
mtojek Jun 7, 2024
47ee9b0
fix
mtojek Jun 7, 2024
4e45761
PR comments
mtojek Jun 10, 2024
d852417
WIP
mtojek Jun 10, 2024
96ca9ae
Fix
mtojek Jun 10, 2024
19fe5cf
fix lint
mtojek Jun 10, 2024
e3a9dba
Merge branch 'main' into 13383-scp
mtojek Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@mtojek
mtojek committed Jun 7, 2024
commit 47ee9b0aafadf1822436a84e691c650c402f830b
3 changes: 1 addition & 2 deletions agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,8 +976,7 @@ func TestAgent_FileTransferBlocked(t *testing.T) {
assertFileTransferBlocked := func(t *testing.T, errorMessage string) {
// NOTE: Checking content of the error message is flaky. It can catch different responses.
isErr := strings.Contains(errorMessage, agentssh.BlockedFileTransferErrorMessage) ||
strings.Contains(errorMessage, "unexpected EOF") ||
strings.Contains(errorMessage, "failed to send packet: EOF") ||
strings.Contains(errorMessage, "EOF") ||
strings.Contains(errorMessage, "Process exited with status 2")
require.True(t, isErr, fmt.Sprintf("Message: "+errorMessage))
}
Expand Down
Loading