chore: accept payload on workspace usage route #13544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jun 13, 2024
cli/portforward.go
Outdated
| @@ -137,7 +137,7 @@ func (r *RootCmd) portForward() *serpent.Command { | |||
| listeners[i] = l | |||
| } | |||
|
|
|||
| stopUpdating := client.UpdateWorkspaceUsageContext(ctx, workspace.ID) | |||
| stopUpdating := client.UpdateWorkspaceUsageContext(ctx, workspace.ID, codersdk.PostWorkspaceUsageRequest{}) | |||
There was a problem hiding this comment.
non-blocking: We might want to expose this as an app named "port-forward" or similar?
There was a problem hiding this comment.
I believe this will require we add a field to the workspace_agent_stats table which is a change I did not want to include in this PR. In general, do you think it's a good idea to add this field given it may impact other features like insights?
There was a problem hiding this comment.
Let's leave it for now. I'd like to avoid any insights changes in the course of this refactor.
johnstcn
approved these changes
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new behavior to the workspace usage endpoint to accept a payload containing an
AgentIDandAppName. This is so the CLI can start informing us of activity based on different "defined apps". This is currently behind an experiment flagworkspace-usagewhich it will stay behind until we are reading to migrate fromworkspace_agent_statstable toworkspace_app_stats.