chore: add additional tailnet topology integration tests #13549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just flaked. |
ethanndickson
commented
Jun 12, 2024
| } | ||
|
|
||
| type derpServer struct { | ||
| http.Handler |
There was a problem hiding this comment.
Following on from your feedback - if we leave the http.Handler unnamed the type only exposes Close and ServeHTTP, which seems sensible.
deansheather
approved these changes
Jun 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality that allows a DERP server or tailnet coordinator to be restarted mid-test.
Added test cases that ensure a client can maintain it's session while either are restarted.
Closes #13460