feat: lint github actions workflows #13552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
37ae19a to
0423938
Compare
matifali
approved these changes
Jun 20, 2024
matifali
approved these changes
Jun 20, 2024
.github/workflows/ci.yaml
Outdated
| @@ -191,6 +191,12 @@ jobs: | |||
| run: | | |||
| make --output-sync=line -j lint | |||
|
|
|||
| - name: Check workflow files | |||
| run: | | |||
| bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/7fdc9630cc360ea1a469eed64ac6d78caeda1234/scripts/download-actionlint.bash) | |||
There was a problem hiding this comment.
Suggested change
| bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/7fdc9630cc360ea1a469eed64ac6d78caeda1234/scripts/download-actionlint.bash) | |
| bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) 1.7.1 |
This will make it easier to bump versions while pinning the version.
ref: https://github.com/rhysd/actionlint/blob/main/docs/install.md#download-script
There was a problem hiding this comment.
Good idea 👍 I've pinned to 1.6.22 which is the version to which the current commit is pointing.
There was a problem hiding this comment.
I suggest we pin to latest availbale just to be sure that linter supports any newly added syntax.
There was a problem hiding this comment.
If we do so, we should update code-server too. See https://github.com/coder/code-server/blob/main/.github/workflows/build.yaml#L142-L152.
@kylecarbs any objections?
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from https://github.com/coder/code-server/blob/0c802ba1652296c79d26ff3e990578e67e6734b1/.github/workflows/build.yaml#L142-L152
Fixes #13413
Credit to @matifali for finding out how we do this already.