Skip to content

chore: implement cli list organization members #13555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2024
Merged

chore: implement cli list organization members #13555

merged 3 commits into from
Jun 12, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 12, 2024 •
edited
Loading 

coder organization members -c username,user_id,organization_roles 
USERNAME        USER ID                               ORGANIZATION ROLES                 
busy-borg3-7M4  342c188b-40e9-4fd9-b678-ff83be5e5114  [Custom Role, Organization Admin]  
testuser        b60a10bb-f03b-48d9-b395-a6f9f3eac76f  []

@Emyrk Emyrk mentioned this pull request Jun 12, 2024
Merged
@Emyrk Graphite App
Copy link
Member Author

Emyrk commented Jun 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Emyrk and the rest of your teammates on Graphite Graphite

This was referenced Jun 12, 2024
Merged
Closed
@Emyrk Emyrk force-pushed the stevenmasley/org_member_cli branch 2 times, most recently from b64c69b to dfded68 Compare June 12, 2024 16:30
@Emyrk Emyrk marked this pull request as ready for review June 12, 2024 16:41
@Emyrk Emyrk requested a review from f0ssel June 12, 2024 16:49
@Emyrk Emyrk mentioned this pull request Jun 12, 2024
Merged
f0ssel
f0ssel approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all stacks look good so far and make sense to me

coderd/members.go
OrganizationID: uuid.UUID{},
})
if err != nil {
// We are missing the display names, but that is not absolutely required. So just
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expecting an error here? I see we can do without it, but I wonder if we should instead of just presenting the error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll return the error 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just unfortunate we can block api calls on this kind of error. Would be nice if we could return some sort of "warning" instead. I'll return an error though as that is what we usually do for failed db calls.

@Emyrk Emyrk force-pushed the stevenmasley/org_member_api branch from c757e52 to 45d4ff7 Compare June 12, 2024 18:38
@Emyrk Emyrk force-pushed the stevenmasley/org_member_cli branch from dfded68 to 1b3a9b7 Compare June 12, 2024 18:38
@Emyrk Emyrk force-pushed the stevenmasley/org_member_api branch from 45d4ff7 to 08e4131 Compare June 12, 2024 18:49
@Emyrk Emyrk force-pushed the stevenmasley/org_member_cli branch 2 times, most recently from e605d37 to d23e335 Compare June 12, 2024 18:53
@Emyrk Emyrk force-pushed the stevenmasley/org_member_api branch from 08e4131 to ce4b854 Compare June 12, 2024 19:26
@Emyrk Emyrk force-pushed the stevenmasley/org_member_cli branch from d23e335 to 9c1fda7 Compare June 12, 2024 19:26
Base automatically changed from stevenmasley/org_member_api to main June 12, 2024 19:52
@Emyrk Emyrk force-pushed the stevenmasley/org_member_cli branch from 9c1fda7 to 0012858 Compare June 12, 2024 19:55
@Emyrk Emyrk merged commit d0fc81a into main Jun 12, 2024
27 checks passed
@Emyrk Emyrk deleted the stevenmasley/org_member_cli branch June 12, 2024 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@f0ssel f0ssel f0ssel approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @f0ssel