Skip to content

feat!: add interface report to coder netcheck #13562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jun 13, 2024

re: #13327

Adds local interfaces to coder netcheck and checks their MTUs for potential problems.

This is mostly relevant for end-user systems where VPNs are common. We could also add it to coderd healthcheck, but until I see coderd connecting to workspaces over a VPN in the wild, I don't think its worth the UX effort.

Netcheck results get the following:

  "interfaces": {
    "error": null,
    "severity": "ok",
    "warnings": null,
    "dismissed": false,
    "interfaces": [
      {
        "name": "lo0",
        "mtu": 16384,
        "addresses": [
          "127.0.0.1/8",
          "::1/128",
          "fe80::1/64"
        ]
      },
      {
        "name": "en8",
        "mtu": 1500,
        "addresses": [
          "192.168.50.217/24",
          "fe80::c13:1a92:3fa5:dd7e/64"
        ]
      }
    ]
  }

Technically not back compatible if anyone is parsing coder netcheck output as JSON, since the original output is now under "derp" in the output.

Copy link
Contributor Author

spikecurtis commented Jun 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis marked this pull request as ready for review June 13, 2024 04:23
@spikecurtis spikecurtis force-pushed the spike/netcheck-interface-report branch from 94b740d to 1b8da82 Compare June 13, 2024 04:36
@spikecurtis spikecurtis force-pushed the spike/netcheck-interface-report branch from 1b8da82 to dcebda4 Compare June 13, 2024 04:52
@spikecurtis spikecurtis changed the title feat: add interface report to coder netcheck feat: expand netcheck to include interface details and small MTU warning Jun 13, 2024
@spikecurtis spikecurtis changed the title feat: expand netcheck to include interface details and small MTU warning !feat: add interface report to coder netcheck Jun 13, 2024
@spikecurtis spikecurtis changed the title !feat: add interface report to coder netcheck feat!: add interface report to coder netcheck Jun 13, 2024
@github-actions github-actions bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Jun 13, 2024
@spikecurtis spikecurtis merged commit fc09077 into main Jun 13, 2024
37 checks passed
@spikecurtis spikecurtis deleted the spike/netcheck-interface-report branch June 13, 2024 06:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants