Skip to content

feat: add interfaces report to support bundle #13563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jun 13, 2024

Adds the InterfacesReport to the coder support bundle

Copy link
Contributor Author

spikecurtis commented Jun 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis requested a review from johnstcn June 13, 2024 06:18
@spikecurtis spikecurtis marked this pull request as ready for review June 13, 2024 06:19
Base automatically changed from spike/netcheck-interface-report to main June 13, 2024 06:19
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but hasn't this already been merged?
https://github.com/coder/coder/pull/13562/files

Copy link
Contributor Author

https://github.com/coder/coder/pull/13562/files is downstack. Because we squash & merge, PRs up the stack can look like they include downstack changes. Lemme restack and push and update...

@spikecurtis spikecurtis force-pushed the 06-13-feat_add_interfaces_report_to_support_bundle branch from bc7fdce to 3de7621 Compare June 13, 2024 08:57
@spikecurtis spikecurtis merged commit 4b0b9b0 into main Jun 13, 2024
27 checks passed
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the 06-13-feat_add_interfaces_report_to_support_bundle branch June 13, 2024 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants